Comment #4 on issue 16234 by [email protected]: Add WebWidget to the WebKit API http://code.google.com/p/chromium/issues/detail?id=16234
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=20854
------------------------------------------------------------------------
r20854 | [email protected] | 2009-07-15 22:11:05 -0700 (Wed, 15 Jul 2009)
| 30 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_gtk.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/render_widget_host_view_win.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/webkit_param_traits.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/print_web_view_helper.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_view_unittest.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_widget.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/render_widget.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/WebCompositionCommand.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/WebNavigationPolicy.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/WebPopupMenu.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/WebTextDirection.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/WebWidget.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/WebWidgetClient.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/chrome_client_impl.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/chromium_bridge_impl.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/context_menu_unittest.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/inspector_client_impl.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframeloaderclient_impl.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webframeloaderclient_impl.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webplugin_impl.cc?r1=20854&r2=20853
A
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpopupmenu_impl.cc
A
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webpopupmenu_impl.h
D /trunk/src/webkit/glue/webtextdirection.h
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webview.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webview_delegate.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webview_impl.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webview_impl.h?r1=20854&r2=20853
D /trunk/src/webkit/glue/webwidget.h
D /trunk/src/webkit/glue/webwidget_delegate.h
D /trunk/src/webkit/glue/webwidget_impl.cc
D /trunk/src/webkit/glue/webwidget_impl.h
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webworker_impl.cc?r1=20854&r2=20853
A
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/window_open_disposition.cc
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/window_open_disposition.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/event_sending_controller.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/mac/test_webview_delegate.mm?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/mac/webview_host.mm?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/mac/webwidget_host.mm?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/plugin_tests.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell_gtk.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell_mac.mm?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell_main.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell_test.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell_win.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_webview_delegate.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_webview_delegate.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_webview_delegate_gtk.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_webview_delegate_win.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/webview_host_gtk.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/webwidget_host.h?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/webwidget_host_gtk.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/webwidget_host_win.cc?r1=20854&r2=20853
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/webkit.gyp?r1=20854&r2=20853
Use WebWidget from the WebKit API. This change also makes
use of WebKitClient (replacing WebWidgetDelegate from glue).
The ripple effects of this change are rather large, but most
of the impact is mechanical.
The more interesting changes include:
1- Removing the WebWidget parameter from WebWidgetClient methods. This
didn't
matter at all to RenderWidget or RenderView, but it did cause some changes
to
be made to TestWebViewDelegate. Now, it is not possible to share a delegate
implementation for both the WebView and a popup menu, so I have a second
instance of the delegate owned by TestShell for use with popup menus.
2- Plumbing WebNavigationPolicy in place of WindowOpenDisposition was
getting
to be a pretty large change, so I stopped short of deleting
WindowOpenDisposition.
That way the Chrome side can remain mostly unmodified. I then added a
mapping
function to convert from WebNavigationPolicy to WindowOpenDisposition.
3- The IME methods on WebWidget were renamed (reviewed separately by
hbono), and
there is now an enum to specify the composition command
(WebCompositionCommand).
4- I added IPC serialization for WebCompositionCommand and WebTextDirection,
which cleaned up some code that was just using ints in IPC messages.
R=jam
BUG=16234
TEST=none
Review URL: http://codereview.chromium.org/149620
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
