Comment #2 on issue 17380 by bugdro...@chromium.org: app startup lets the  
menubar draw before we have localization support active
http://code.google.com/p/chromium/issues/detail?id=17380

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=21272

------------------------------------------------------------------------
r21272 | thoma...@chromium.org | 2009-07-22 07:04:27 -0700 (Wed, 22 Jul  
2009) | 15 lines
Changed paths:
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/build/mac/generate_localizer
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chromium_strings.grd?r1=21272&r2=21271
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=21272&r2=21271
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/google_chrome_strings.grd?r1=21272&r2=21271
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/MainMenu.xib?r1=21272&r2=21271
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/DEPS?r1=21272&r2=21271
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/app_controller_mac.mm?r1=21272&r2=21271
    D /trunk/src/chrome/browser/cocoa/menu_localizer.h
    D /trunk/src/chrome/browser/cocoa/menu_localizer.mm
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/ui_localizer.h
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/ui_localizer.mm
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/ui_localizer_unittest.mm
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/render_view_context_menu_mac.mm?r1=21272&r2=21271
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=21272&r2=21271

Starting mac l10n:
   Added a script to process a xib file and generate a localizer out of the  
resource constants it finds in the xib.
   Update the MainMenu.xib to use a generated localizer.
   Kill off the menu_localizer in favor of a generated one.
   ui_localizer is a helper so each "localizer" is as small as possible.
   Build some menus out of base strings and the product name like windows.
Added the dir generated for the localizers so we can load the header to  
directly create them (menubar one).
Enable the other 3 languages we were building to help test.
Made the context menu code use the new code for handling window's  
accelerators and ellipsis.
Added unittest for ui_localizer.
Opened http://crbug.com/17380 to track the problem with the menu titles so  
I can move on to other parts of the UI for now.

TEST=The main menu will have some items localized now (and more will be  
localizable in the TC).
BUG=16764
Review URL: http://codereview.chromium.org/155774
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to