Comment #7 on issue 17560 by bugdro...@chromium.org: Clicking a link that
results in a download from Gmail makes a tab that won't close
http://code.google.com/p/chromium/issues/detail?id=17560
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=21806
------------------------------------------------------------------------
r21806 | lafo...@chromium.org | 2009-07-27 19:48:30 -0700 (Mon, 27 Jul
2009) | 25 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/browser.cc?r1=21806&r2=21805
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/renderer_host/render_view_host.cc?r1=21806&r2=21805
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/renderer_host/render_view_host.h?r1=21806&r2=21805
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/renderer_host/render_view_host_delegate.h?r1=21806&r2=21805
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/tab_contents/render_view_host_manager.cc?r1=21806&r2=21805
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/tab_contents/render_view_host_manager.h?r1=21806&r2=21805
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/tab_contents/tab_contents.cc?r1=21806&r2=21805
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/tab_contents/tab_contents.h?r1=21806&r2=21805
Merge 21685 - Relanding r21673 without reenabling the BrowserTest, which
apparently is
still failing.
Make downloads not prevent tabs from closing. If a download creates a
crosssite transition (for example, if you click a link in Gmail that results
in a download in a new tab), that tab will be stuck and you can't close it
or
the browser. This is the opposite problem with a similar cause as bug
16246. In
both cases we were using some secondary signal to tell us if we're closing
for
a cross site transition or closing the tab, and that signal was wrong. In
this
case, we were running the onunload handler, but because there was a pending
RenderViewHost, the RenderManager would think that the close was a crosssite
one, and not forward the close message to actually close the tab. This patch
adds a flag to the on unload handlers that indicates whether it's for a tab
closure or a crosssite transition, so we can do the right thing
unambiguously
when the message returns. In this case I keep this information in the
RenderView in case we send multiple close requests, we'll close the tab if
any
of them were for the entire tab, even if that particular one was dropped
because we don't want to have more than one in flight at once. BUG=17560
TEST=none.
Review URL: http://codereview.chromium.org/160122
Review URL: http://codereview.chromium.org/159426
tbr=bre...@chromium.org
Review URL: http://codereview.chromium.org/160249
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
