Updates:
Status: Fixed
Comment #4 on issue 17486 by [email protected]: video crash in
AlsaPCMOutputStream on tab close.
http://code.google.com/p/chromium/issues/detail?id=17486
Forgot BUG link in changelist, so here's the info.
r22414 | [email protected] | 2009-08-04 14:49:12 -0700 (Tue, 04 Aug 2009)
| 1979
lines
Changed Paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/audio_output.h?
r1=22414&r2=22413
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/linux/alsa_output.cc?
r1=22414&r2=22413
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/linux/alsa_output.h?
r1=22414&r2=22413
A
http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/linux/alsa_output_unittes
t.cc?view=log
A
http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/linux/alsa_wrapper.cc?
view=log
A
http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/linux/alsa_wrapper.h?
view=log
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/linux/audio_manager_linux
.cc?r1=22414&r2=22413
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/audio/linux/audio_manager_linux
.h?r1=22414&r2=22413
M
http://src.chromium.org/viewvc/chrome/trunk/src/media/media.gyp?r1=22414&r2=22413
Reimplement the AlsaPcmOutputStream and fix the threading issues.
Changes the threading model from one thread per stream to one shared
thread. Also,
redoes the alsa reading/buffering logic to assume an asynchronous data
source, and
respect the different packet sizes. The Alsa device is set to non-blocking
now.
State transitions are cleaned up, and the threading semantics are
reworked. Now
linux audio will no longer crash on shutdown, seek, pause, or tab close.
This
implementation does still leak though. :( The leak will be fixed in
another CL.
Review URL: http://codereview.chromium.org/160497
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
