Comment #3 on issue 18203 by bugdro...@chromium.org: Clicking on Flash plugins often doesn't work on the Mac http://code.google.com/p/chromium/issues/detail?id=18203
The following revision refers to this bug: http://src.chromium.org/viewvc/chrome?view=rev&revision=22799 ------------------------------------------------------------------------ r22799 | stuartmor...@google.com | 2009-08-07 15:03:17 -0700 (Fri, 07 Aug 2009) | 10 lines Changed paths: A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_carbon_interpose_mac.cc M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_process_host.cc?r1=22799&r2=22798 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=22799&r2=22798 A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/plugin_carbon_interpose_constants_mac.cc A http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/plugin_carbon_interpose_constants_mac.h M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/plugin/plugin_main.cc?r1=22799&r2=22798 A http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.cc A http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/fake_plugin_window_tracker_mac.h M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/webplugin_delegate_impl_mac.mm?r1=22799&r2=22798 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/webkit.gyp?r1=22799&r2=22798 Set up a interposing library for Carbon calls made by plugins. This gives us a library that's inserted into plugin process via DYLD_INSERT_LIBRARIES to intercept Carbon calls, and moves the window/process activation handling into that library (based on Carbon window activation/deactivation calls, rather than polling the front window). Over time we'll interpose more, but this gives us the foundation. This fixes both the "window loses focus when loading a page with plugins" and "can't click on YouTube controls" bugs. BUG=18203,18553 TEST=Clicking on Flash plugins should work much more reliably, opening a page with a plugin shouldn't cause the window to lose focus. Review URL: http://codereview.chromium.org/164100 ------------------------------------------------------------------------ -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---