Comment #4 on issue 17088 by bugdro...@chromium.org: [MLK]
Pickle::Resize(UINT) [CHROME.DLL] in multiple tests
http://code.google.com/p/chromium/issues/detail?id=17088
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=22826
------------------------------------------------------------------------
r22826 | j...@chromium.org | 2009-08-07 16:13:35 -0700 (Fri, 07 Aug 2009) |
16 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/pickle.cc?r1=22826&r2=22825
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/pickle.h?r1=22826&r2=22825
Add short circuit case for self assignment, and add virtual destructor
Pickle is a base class of Message, which has a virtual destructor, so
it is better to have Pickle have a virtual destructor as well.
Add more defensive code in the case of self assignment.
**IF** self assignment was used, and the target was read-only,
then the existing code would have a memory fault.
I don't think this is currently possible in use cases, but
the defensize code is much better. (per suggestion from CPU
on last CL).
BUG=17027
BUG=17088
r=cpu
Review URL: http://codereview.chromium.org/159800
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
