Comment #7 on issue 18837 by [email protected]: Crash -
JumpList::OnFavIconDataAvailable(int,bool,scoped_refptr<RefCountedVector<unsigned
char> >,bool,GURL)
http://code.google.com/p/chromium/issues/detail?id=18837
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=23258
------------------------------------------------------------------------
r23258 | [email protected] | 2009-08-12 17:02:58 -0700 (Wed, 12 Aug
2009) | 13 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/195/src/chrome/browser/jumplist.cc?r1=23258&r2=23257
Merge 22907 - A blind fix for Issue 18837 (and a build fix for VS2008)
To read this crash dump, this issue is caused by my mistake that this
jumplist.cc calls "icon_urls_.front()" for an empty list.
This change added some checks that verifies a std::list has one or more
items.
This change also fixes linker errors because of conflicted symbols:
CLSID_DestinationList and CLSID_EnumerableObjectCollection, which is caused
by my mistake that I forgot removing "EXTERN_C" keywords when I moved them
into an anonymous namespace. This change removes the "EXTERN_C" keywords
for VS2008.
BUG=18837 "Crash
JumpList::OnFavIconDataAvailable(int,bool,scoped_refptr<RefCountedVector<unsigned
char> >,bool,GURL)"
TEST=Show JumpList on Windows 7.
TEST=Build Chromium with VS2008.
Review URL: http://codereview.chromium.org/159853
[email protected]
Review URL: http://codereview.chromium.org/165424
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
