Comment #10 on issue 17938 by bugdro...@chromium.org: ReadWebPluginInfo should not happen on IO thread http://code.google.com/p/chromium/issues/detail?id=17938
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=23420
------------------------------------------------------------------------
r23420 | j...@chromium.org | 2009-08-13 22:24:21 -0700 (Thu, 13 Aug 2009) |
7 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_service.cc?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/metrics/metrics_service.h?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_service.cc?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/plugin_service.h?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/buffered_resource_handler.cc?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/buffered_resource_handler.h?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.cc?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_dispatcher_host.h?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_handler.h?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_message_filter.cc?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/resource_message_filter.h?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_plugin_lib.cc?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/renderer_glue.cc?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/plugin_lib.cc?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/plugin_list.cc?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/plugin_list.h?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/plugin_list_linux.cc?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/plugin_list_mac.mm?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/plugin_list_win.cc?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webkit_glue.h?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webkitclient_impl.cc?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell_gtk.cc?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell_mac.mm?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_shell_win.cc?r1=23420&r2=23419
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/test_shell/test_worker/test_worker_main.cc?r1=23420&r2=23419
Ensure we don't load plugins on the IO thread.
I had to move the locks from PluginService to PluginList, so that a lock
(which can block other threads) isn't held while loading the plugins.
BUG=17938
TEST=added asserts which crash if plugins loaded on IO thread, current UI
tests exercise them
Review URL: http://codereview.chromium.org/164305
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
