Comment #6 on issue 19631 by bugdro...@chromium.org: Tabbing on Omnibox
enters in to search UI mode
http://code.google.com/p/chromium/issues/detail?id=19631
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=24052
------------------------------------------------------------------------
r24052 | su...@chromium.org | 2009-08-21 17:25:04 -0700 (Fri, 21 Aug 2009)
| 14 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.cc?r1=24052&r2=24051
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/autocomplete/autocomplete_edit_view_gtk.h?r1=24052&r2=24051
Implements unimplemented methods of AutocompleteEditViewGtk and fixes a
regression issue.
This CL implements two unimplemented methods of AutocompleteEditViewGtk:
OnRevertTemporaryText() and IsSelectAll().
The implementation are mostly copied from autocomplete_edit_view_mac.mm.
Some grammer errors and a valgrind warning introduced by CL 165457 are also
fixed.
This CL was just updated to fix a regression caused by CL 165457 (issue
19631).
BUG=19631: Tabbing on Omnibox enters in to search UI mode
TEST=Input something in omnibox and make sure some text is selected and
popup view is opened, change current selection in popup view by pressing
up/down then press escape to see if omnibox is reverted to its original
content and selection.
TEST=Make sure www.google.com is one of the search engine, open
www.google.com then move the focus back to omnibox and press tab to see if
the focus is moved into web page.
Review URL: http://codereview.chromium.org/172041
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
