Updates:
Summary: Find bar's highlighting of initial text shouldn't update
PRIMARY
X selection
Labels: -Mstone-LinuxBeta Mstone-X
Comment #13 on issue 12392 by [email protected]: Find bar's highlighting
of initial text shouldn't update PRIMARY X selection
http://code.google.com/p/chromium/issues/detail?id=12392
I think I'm going to punt on this for now. Here are the issues that I know
of:
- The find bar currently uses a GtkEntry widget. GtkEntry lacks functions
to
temporarily detach GtkClipboards from it, which is the hack that we use in
the omnibox's
GtkTextView to highlight text without updating PRIMARY.
- I've tried switching the find bar to use GtkTextView instead, but that
seems like it
might open us up to a bunch of the same things we need to work around in
the omnibox
(but maybe we're already susceptible to those issues and haven't noticed).
In any case,
though, GtkTextView doesn't support enabling or disabling a shadowed border
being drawn
around it, which GtkEntry *does* (GtkTextView seems to never have a
border). We
currently enable the find bar's GtkEntry's border when we're using the GTK
theme. It
may be possible to manually draw a border around a GtkTextView using a
GtkEventBox, but
we'll still end up with it not showing the focused/unfocused state
correctly (but maybe
this isn't that big of a problem, since the non-GTK omnibox and find bar
don't show
focused state either).
- I looked into deriving a class from GtkEntry that adds additional
functions to
enable/disable updating the PRIMARY selection, but GtkEntry's code to
select text uses a
bunch of private stuff that I wouldn't be able to access from my class.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
