Comment #2 on issue 17343 by bugdro...@chromium.org: Create a NullableString16 class for transporting WebStrings (nulls and all) across the IPC barrier http://code.google.com/p/chromium/issues/detail?id=17343
The following revision refers to this bug: http://src.chromium.org/viewvc/chrome?view=rev&revision=24574 ------------------------------------------------------------------------ r24574 | jor...@chromium.org | 2009-08-26 17:55:02 -0700 (Wed, 26 Aug 2009) | 14 lines Changed paths: M http://src.chromium.org/viewvc/chrome/trunk/src/base/base.gyp?r1=24574&r2=24573 A http://src.chromium.org/viewvc/chrome/trunk/src/base/nullable_string16.h M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.cc?r1=24574&r2=24573 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/in_process_webkit/dom_storage_dispatcher_host.h?r1=24574&r2=24573 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/render_messages_internal.h?r1=24574&r2=24573 M http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/renderer_webstoragearea_impl.cc?r1=24574&r2=24573 M http://src.chromium.org/viewvc/chrome/trunk/src/ipc/ipc_message_utils.h?r1=24574&r2=24573 M http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/WebString.h?r1=24574&r2=24573 Add a nullable string16 class to base. It combines a string16 + a null param in order to cover all the possible states of a WebKit string. For strings where the null state is not meaninfully different from the empty state, this class should NOT be used. There are, however, some cases where we do need to track null. LocalStorage is an example. This class should be a fairly light weight way to do so. This change also adds implicit conversion to and from WebStrings. This also switches LocalStorage's IPCs over to using this new class. BUG=17343 TEST=none Review URL: http://codereview.chromium.org/174484 ------------------------------------------------------------------------ -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---