Status: Unconfirmed
Owner: ----
Labels: OS-Linux Area-Misc Size-Medium Type-Bug

New issue 20772 by joel.stan: Make Webkit obey GTK cursor blink preferences
http://code.google.com/p/chromium/issues/detail?id=20772

Dean wrote:
> A long time ago I spent some time making sure that the Chromium GTK
> webkit stuff honored the cursor blink speed of GTK, and fixed in
> webkit, etc.  It seems that since it regressed, by my old comment is
> still there:

> double RenderThemeChromiumLinux::caretBlinkInterval() const
> {
>     // Disable the blinking caret in layout test mode, as it introduces
>     // a race condition for the pixel tests. http://b/1198440
>     if (ChromiumBridge::layoutTestMode())
>         return 0;

>     // We cache the interval so we don't have to repeatedly request it
from > gtk.
>     return 0.5;
> }


> Where we return 0.5, we used to do what the comment says and ask GTK
> for the blink speed.

> I am guessing this got ripped out when Adam removed GTK from the
> renderer.  I would like to still honor GTK here, it is really nice on
> remote X if you set your cursor not to blink, and you avoid needless
> painting a few times a second.

> What's the best way to go about it, pipe it through webkit glue and
> into the browser over IPC?

The suggestion was:

> We can perhaps stick the GTK theme related stuff into WebPreferences
> (maybe a struct inside it?).  All the existing IPCs with
> WebPreferences are probably good times to set new GTK settings (cursor
> blink, selection color, etc).

> While you're at it, we could plumb through the selection color.  Looks
> weird for the omnibox highlight to not match the on-page highlight.

> note that on both Windows and Linux you get a message when these
> settings change, so for full credit make it so the info is sent as a
> separate IPC and not just part of the startup info.  :)

I will work on this.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to