Status: Assigned
Owner: [email protected]
Labels: Type-Bug Pri-2 OS-All Area-WebKit Size-Medium LayoutTests

New issue 20987 by [email protected]: Need to hook up bindings for  
event.persisted
http://code.google.com/p/chromium/issues/detail?id=20987

http://trac.webkit.org/changeset/47824 added some tests.  We don't pass
2 of them because we don't return false for event.persisted.  This is  
related
to the page cache, so it's _possible_ we won't want to hook it up, but I'm
guessing it's something easy that we should just go ahead and fix.  Sample
diffs:

--- /Files/src/chrome3/src/webkit/Release/layout-test-
results/LayoutTests/fast/events/pageshow-pagehide-simp-expected.txt
+++ /Files/src/chrome3/src/webkit/Release/layout-test-
results/LayoutTests/fast/events/pageshow-pagehide-simp-actual.txt
@@ -7,21 +7,21 @@

  ***Original load - onload and pageshow events should fire for subframes,
and then for main frame***
  Subsubframe window.onload
-Subsubframe window.onpageshow, target = [object HTMLDocument],
persisted = false
+Subsubframe window.onpageshow, target = [object HTMLDocument],
persisted = undefined
  Subframe window.onload
-Subframe window.onpageshow, target = [object HTMLDocument],
persisted = false
+Subframe window.onpageshow, target = [object HTMLDocument],
persisted = undefined
  Main frame window.onload
-Main frame window.onpageshow, target = [object HTMLDocument],
persisted = false
+Main frame window.onpageshow, target = [object HTMLDocument],
persisted = undefined
  ***Navigating bottom-level subframe, onpagehide events should fire for
subsubframe***
-Subsubframe window.onpagehide, target = [object HTMLDocument],
persisted = false
+Subsubframe window.onpagehide, target = [object HTMLDocument],
persisted = undefined
  Subsubframe window.onunload
  Subsubframe window.onload
-Subsubframe window.onpageshow, target = [object HTMLDocument],
persisted = false
+Subsubframe window.onpageshow, target = [object HTMLDocument],
persisted = undefined
  ***Navigating mid-level subframe, onpagehide events should fire for both
subframes***
-Subframe window.onpagehide, target = [object HTMLDocument],
persisted = false
+Subframe window.onpagehide, target = [object HTMLDocument],
persisted = undefined
  Subframe window.onunload
-Subsubframe window.onpagehide, target = [object HTMLDocument],
persisted = false
+Subsubframe window.onpagehide, target = [object HTMLDocument],
persisted = undefined
  Subsubframe window.onunload
  Subframe window.onload
-Subframe window.onpageshow, target = [object HTMLDocument],
persisted = false
+Subframe window.onpageshow, target = [object HTMLDocument],
persisted = undefined
  ***Done***

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to