Comment #2 on issue 21762 by bugdro...@chromium.org: Manage search window  
doesn't remember position/size
http://code.google.com/p/chromium/issues/detail?id=21762

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=26646

------------------------------------------------------------------------
r26646 | rse...@chromium.org | 2009-09-18 18:54:23 -0700 (Fri, 18 Sep 2009)  
| 12 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/EditSearchEngine.xib?r1=26646&r2=26645
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_prefs.cc?r1=26646&r2=26645
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/edit_search_engine_cocoa_controller.mm?r1=26646&r2=26645
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/keyword_editor_cocoa_controller.mm?r1=26646&r2=26645
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/nswindow_local_state.h
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/nswindow_local_state.mm
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/nswindow_local_state_unittest.mm
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/page_info_window_controller.h?r1=26646&r2=26645
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/page_info_window_controller.mm?r1=26646&r2=26645
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/page_info_window_controller_unittest.mm?r1=26646&r2=26645
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/preferences_window_controller.h?r1=26646&r2=26645
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/preferences_window_controller.mm?r1=26646&r2=26645
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/search_engines/keyword_editor_controller.cc?r1=26646&r2=26645
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/search_engines/keyword_editor_controller.h?r1=26646&r2=26645
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=26646&r2=26645
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.cc?r1=26646&r2=26645
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.h?r1=26646&r2=26645

[Mac] Polish the search engine manager

* Make the edit search engine window a sheet.
* Only allow one instance of the search engine manager to be opened at once.
* The search engine manager now remembers its position.
* Create NSWindow(LocalStateAdditions) category to assist with storing  
window
   position in Chromium's local state.

BUG=21761,21762,21883,21996
TEST=Editing/adding a search engine happens in a sheet. Press [Manage]  
multiple times and only 1 window should open. Press [Manage] and the window  
should be at its last position.

Review URL: http://codereview.chromium.org/207027
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to