Comment #6 on issue 20451 by [email protected]: It is easy to get a zombie http://code.google.com/p/chromium/issues/detail?id=20451
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=27961
------------------------------------------------------------------------
r27961 | [email protected] | 2009-10-03 15:17:54 -0700 (Sat, 03 Oct 2009) |
8 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings.grd?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ar.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_bg.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_bn.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ca.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_cs.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_da.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_de.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_el.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_en-GB.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_es-419.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_es.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_et.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_fi.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_fil.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_fr.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_gu.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_he.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_hi.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_hr.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_hu.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_id.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_it.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ja.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_kn.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ko.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_lt.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_lv.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ml.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_mr.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_nb.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_nl.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_or.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_pl.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_pt-BR.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_pt-PT.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ro.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ru.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_sk.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_sl.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_sr.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_sv.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_ta.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_te.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_th.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_tr.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_uk.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_vi.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_zh-CN.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/resources/locale_settings_zh-TW.xtb?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/confirm_message_box_dialog.cc?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/confirm_message_box_dialog.h?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/passwords_page_view.cc?r1=27961&r2=27960
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/options/passwords_page_view.h?r1=27961&r2=27960
Change ConfirmMessageBoxDialog to just be a native view (it was only
windows before, too, but now at least it doesn't
cause zombie processes) with an observer that is notified when the user
clicks OK/closes the dialog instead of running
a nested message loop and blocking. This fixes bug 20451, where nested
message loops were running a confirm dialog and
could cause zombie processes at browser shutdown.
BUG=20451
TEST=None (manual: verify that the confirmation dialog is shown when you
try to remove all passwords, and that no zombie is left behind if the
browser is closed while the confirmation dialog is showing)
Review URL: http://codereview.chromium.org/243054
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
