Comment #3 on issue 24671 by bugdro...@chromium.org: It should be legal to  
include zero icons in a browser action
http://code.google.com/p/chromium/issues/detail?id=24671

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=29097

------------------------------------------------------------------------
r29097 | a...@chromium.org | 2009-10-14 23:36:08 -0700 (Wed, 14 Oct 2009) | 5  
lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/chrome_dll_resource.h?r1=29097&r2=29096
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=29097&r2=29096
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.cc?r1=29097&r2=29096
    D /trunk/src/chrome/browser/extensions/browser_action_apitest.cc
    A  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/browser_action_test.cc
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_apitest.cc?r1=29097&r2=29096
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_apitest.h?r1=29097&r2=29096
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_actions_api.cc?r1=29097&r2=29096
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browser_actions_api.h?r1=29097&r2=29096
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_actions_toolbar_gtk.cc?r1=29097&r2=29096
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_actions_container.cc?r1=29097&r2=29096
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.cc?r1=29097&r2=29096
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/toolbar_view.h?r1=29097&r2=29096
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=29097&r2=29096
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.cc?r1=29097&r2=29096
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/extensions/extension_action.h?r1=29097&r2=29096
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/resources/extension_process_bindings.js?r1=29097&r2=29096
    D  
/trunk/src/chrome/test/data/extensions/api_test/browser_action/background.html
    D /trunk/src/chrome/test/data/extensions/api_test/browser_action/icon.png
    D  
/trunk/src/chrome/test/data/extensions/api_test/browser_action/icon2.png
    D  
/trunk/src/chrome/test/data/extensions/api_test/browser_action/manifest.json
    D  
/trunk/src/chrome/test/data/extensions/api_test/browser_action/update.html
    D  
/trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/background.html
    D  
/trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/manifest.json
    D  
/trunk/src/chrome/test/data/extensions/api_test/browser_action_no_icon/update.html

Reverting r29095 (removes wrench integration for
browser actions).

tbr=mpcompl...@chromium.org
BUG=24379,24671
------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---

Reply via email to