Comment #5 on issue 24367 by [email protected]: Canceling "bookmark all tabs" still creates the folder http://code.google.com/p/chromium/issues/detail?id=24367
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=29343
------------------------------------------------------------------------
r29343 | [email protected] | 2009-10-16 15:28:44 -0700 (Fri, 16 Oct 2009) |
20 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_context_menu_controller.cc?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_editor.h?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_utils.cc?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/bookmarks/bookmark_utils.h?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.cc?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_editor_controller.mm?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_bubble_gtk.cc?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_context_menu_gtk.cc?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_editor_gtk.cc?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_editor_gtk.h?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_editor_gtk_unittest.cc?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_manager_gtk.cc?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_tree_model.cc?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/bookmark_tree_model.h?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/sync/glue/change_processor.cc?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_bubble_view.cc?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_editor_view.cc?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_editor_view.h?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/bookmark_editor_view_unittest.cc?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/tabs/tab.cc?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/live_sync/bookmark_model_verifier.cc?r1=29343&r2=29342
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/live_sync/two_client_live_bookmarks_sync_test.cc?r1=29343&r2=29342
Makes canceling 'bookmark all tabs' delete the folder. Or rather,
makes it so that bookmark all tabs only creates the folder if the user
presses ok. I wasn't happy adding another random arg to
BookmarkEditor::Show, so I added in a structure an enum. This makes it
clearer what Show should do.
I also fixed the following:
. On gtk we wouldn't always pick the right parent for nodes.
. The context menu item is now enabled on views/gtk.
And this now breaks the mac side. I'll straighten that out right after
landing this.
BUG=24367
TEST=Make sure 'bookmark all tabs' works, as well as the bookmark
editor work. (get to the bookmark editor by creating a new bookmark,
then clicking edit, or right clicking a bookmark on the bookmark bar and
choosing edit).
Review URL: http://codereview.chromium.org/271115
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
