Comment #5 on issue 25562 by [email protected]: Page actions with no
icon crash Chrome when trying to enable
http://code.google.com/p/chromium/issues/detail?id=25562
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=29867
------------------------------------------------------------------------
r29867 | [email protected] | 2009-10-22 20:01:47 -0700 (Thu, 22 Oct 2009)
| 20 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_browsertests_misc.cc?r1=29867&r2=29866
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/extensions/extension_page_actions_module.cc?r1=29867&r2=29866
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/location_bar_view_gtk.cc?r1=29867&r2=29866
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/location_bar_view.cc?r1=29867&r2=29866
D /trunk/src/chrome/test/data/extensions/browsertest/crash_25562
Revert 29861 since this fail on the interactive
linux dbg bot, for some weird reason...
Page actions that don't specify an icon (ie.
have a spelling error in the manifest, such as
icon instead of icons/default_icon) caused a
crash when they try to display their icon.
We now check when the extension tries to enable
the page action whether there are any icons to
display. If not, we don't proceed and log an
error to the console.
TBR=nsylvain
BUG=25562
TEST=Covered by browser test.
Review URL: http://codereview.chromium.org/316018
[email protected]
Review URL: http://codereview.chromium.org/327007
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
