Comment #12 on issue 24493 by [email protected]: Theme loading is
slow, done on demand and done on the UI thread
http://code.google.com/p/chromium/issues/detail?id=24493
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=29904
------------------------------------------------------------------------
r29904 | [email protected] | 2009-10-23 10:39:53 -0700 (Fri, 23 Oct 2009) | 20
lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/async_resource_handler.cc?r1=29904&r2=29903
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/renderer_host/async_resource_handler.h?r1=29904&r2=29903
When sending resources across the IPC barrier, use increasing sized buffers.
AsyncResourceHandler::OnWillRead will usually allocate a new piece of shared
memory for each 32 kilobyte chunk of a resource to be sent over IPC from the
browser to the renderer. Instead, use a 32k chunk, then a 64k chunk, then a
128k chunk up to a maximum size of 512k.
Why? Because transferring large resources is really slow. To send a
sequence of
32k chunks to the renderer, we need to wait for the renderer to send an ACK
message back before we send the next chunk.
The themeing on the new tab page is a pathological case for this code. Most
of
the background images are large, and my test case is about 800k. This was 25
round trips. Now it is 5. According to the web inspector, it used to take
~700ms to transfer said image. Now
it's in the ~30ms range. It feels faster, and the web inspector shows the
speed up, but tab_complex_theme_cold does not...
BUG=http://crbug.com/24493
TEST=Doesn't regress any performance tests.
Review URL: http://codereview.chromium.org/331001
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
