Comment #4 on issue 24885 by [email protected]: DCHECK is not friendly to googletest's "death tests" on Windows http://code.google.com/p/chromium/issues/detail?id=24885
We do need to check if it fails. Well, basically your question is "Do we need death tests in chromium?" - because any death test dies on either CHECK or DCHECK or something similar. Currently, AFAIK, AtomicFlagTest.DoubleSetDeathTest is the only death test. I wonder why. I've noticed the issue when writing http://codereview.chromium.org/276002 This class is written in such a way that Set() can only be called once (on purpose). If someone wants to remove this DCHECK, this won't be a proper synchronization class anymore (there are lots of ins and outs, we had a long discussion with Darin and Mike Burrows about it). Without the DCHECK all correct tests will remain correct but someone may use the class in a wrong way. We want to have a test to make sure nobody deletes the DCHECK in the future. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
