Status: Untriaged Owner: [email protected] CC: [email protected], [email protected], [email protected], [email protected] Labels: OS-Mac Area-BrowserUI Pri-2 Type-Bug
New issue 25946 by [email protected]: global_keyboard_shortcut_macs uses keycodes for all shortcuts http://code.google.com/p/chromium/issues/detail?id=25946 While working on that |cr_firesForKeyEvent:| CL (http://codereview.chromium.org/319001 ), it occurred to me that global_keyboard_shortcuts_mac is keycode-based. That is fine for shortcuts that are on the same physical position on all keyboards (e.g. arrows keys, backspace) but less fine in other cases. The most problematic shortcut is probably cmd-shift-[/]. On US layouts, this is cmd-{/}, which makes sense. On German keyboards, this is cmd-Ü/* which is worse. On French layouts, it's cmd-¨/*. And so on. (cmd-* is a system shortcut for "evaluate selection as applescript", so this even conflicts with a system shortcut). Doing this by character match instead of by keycode match is not much better, because "{" is pretty hard to type in german (but that's ok, that's why we have cmd-opt-left/right and ctrl-tab, I guess). Another conflict is cmd-1-9 for "switch to nth tab". On some keyboards (e.g. italian and french), you have to press shift to get a number and get some glyph if you just hit the "1" key (e.g. "&" for 1 on a french layout). Doing this by keycode might actually be ok (it's more convenient to type, and I couldn't see any shortcut conflicts for french and italian – cmd-& and friends don't seem to be used often). In Safari however, cmd-"1" doesn't do anything with an italian keyboard (neither does cmd-shift-"1"). All the other shortcuts look fine. Thoughts? I'd say leave cmd-1-9 as is, but change cmd-{/} into a character-based instead of keycode-based shortcut. Please cc people who might have an opinion here. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs -~----------~----~----~----~------~----~------~--~---
