Comment #1 on issue 25213 by [email protected]: Invalid resource size is reported http://code.google.com/p/chromium/issues/detail?id=25213
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=30725
------------------------------------------------------------------------
r30725 | [email protected] | 2009-11-02 10:45:07 -0800 (Mon, 02 Nov 2009) |
9 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/debugger/devtools_sanity_unittest.cc?r1=30725&r2=30724
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/devtools/image.html
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/data/devtools/image.png
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/public/WebURLLoaderClient.h?r1=30725&r2=30724
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/api/src/ResourceHandle.cpp?r1=30725&r2=30724
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/devtools/js/tests.js?r1=30725&r2=30724
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/ftp_directory_listing_response_delegate.cc?r1=30725&r2=30724
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/multipart_response_delegate.cc?r1=30725&r2=30724
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/multipart_response_delegate_unittest.cc?r1=30725&r2=30724
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/resource_fetcher.cc?r1=30725&r2=30724
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/resource_fetcher.h?r1=30725&r2=30724
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webplugin_impl.cc?r1=30725&r2=30724
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/webplugin_impl.h?r1=30725&r2=30724
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/weburlloader_impl.cc?r1=30725&r2=30724
DevTools: report correct content length for resources.
Currently lengthReceived always has the same value as dataLength when
Safari calls ResourceHandle::didReceiveData. In Chrome expected content
length is passed as lengthReceived parameter which leads to incorrect
content length to be stored in InspectorResource. InspectorResource expects
lengthReceived to be the length of current data chunk(see
InspectorResource::addLength). So I changed lengthReceived parameter to be
dataLength.
Darin, I see your TODO comment at line 581 in
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/weburlloader_impl.cc?annotate=6296
(the comment was deleted later) so I think you are right person to review
the change in weburlloader_impl.cc. Please look at weburlloader_impl.cc and
feel free to leave devtools specific changes to Alex and Pavel.
BUG=25213
TEST=DevToolsSanityTest.TestResourceContentLength
Review URL: http://codereview.chromium.org/295041
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
