Comment #5 on issue 22738 by [email protected]: CFInstall.js doesn't
allow to dismiss installation iframe
http://code.google.com/p/chromium/issues/detail?id=22738
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=31539
------------------------------------------------------------------------
r31539 | [email protected] | 2009-11-09 19:16:31 -0800 (Mon, 09 Nov
2009) | 11 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/CFInstall.js?r1=31539&r2=31538
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/chrome_frame_unittests.cc?r1=31539&r2=31538
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_basic.html
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_dismiss.html
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_overlay.html
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/CFInstall_place.html
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/data/chrome_frame_tester_helpers.js?r1=31539&r2=31538
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome_frame/test/http_server.cc?r1=31539&r2=31538
Updates CFInstall.js to:
* provide a new 'overlay' prompt mode that includes a "close" button with
a cookie that respects the user preference for any originating site
* handle requesting the install UI from a host page loaded from a file://
URL
* expands UA detection to stop taunting Win2K (and below) users with
visions of WebKit goodness
* preserves full compat with previous version
BUG=23057,22738,23132
TEST=see new test files in this change or build chrome_frame_tests and run
with: chrome_frame_tests.exe --gtest_filter=*CFInstall*
Review URL: http://codereview.chromium.org/345032
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
-~----------~----~----~----~------~----~------~--~---
