Comment #6 on issue 25600 by bugdro...@chromium.org: Bookmark bar presentation should animate. http://code.google.com/p/chromium/issues/detail?id=25600
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=31977
------------------------------------------------------------------------
r31977 | viettrung...@chromium.org | 2009-11-13 17:01:17 -0800 (Fri, 13 Nov
2009) | 12 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/nibs/BookmarkBar.xib?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.h?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/animatable_view.h?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_bridge_unittest.mm?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.h?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller.mm?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_controller_unittest.mm?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.h?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view.mm?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_bar_toolbar_view_unittest.mm?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.h?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller.mm?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_controller_unittest.mm?r1=31977&r2=31976
D /trunk/src/chrome/browser/cocoa/toolbar_compressable.h
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.h?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller.mm?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/toolbar_controller_unittest.mm?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/view_resizer_pong.mm?r1=31977&r2=31976
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=31977&r2=31976
Mac: Animate the bookmark bar showing/hiding.
There's a huge refactoring of the bookmark bar controller in this CL, so
that animation-related code is in only a few places (instead of scattered
all over the place).
Changes to BookmarkBar.xib: Since BookmarkBarToolbarView now inherits from
AnimatableView, I had to hook up its delegate_ member to File's Owner
(i.e., the BookmarkBarController).
Not yet implemented: morphing between the detached bar (on the NTP) and
anything else.
BUG=25600
TEST=Go to a normal page, show/hide the bookmark bar (Shift-Cmd-B), watch
it animate.
Review URL: http://codereview.chromium.org/384105
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
