Comment #1 on issue 27164 by bugdro...@chromium.org: plugins open layout tests are failing. http://code.google.com/p/chromium/issues/detail?id=27164
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=31991
------------------------------------------------------------------------
r31991 | ana...@chromium.org | 2009-11-13 19:23:32 -0800 (Fri, 13 Nov 2009)
| 17 lines
Changed paths:
A
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/plugins/document-open-expected.txt
A
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-linux/LayoutTests/plugins/window-open-expected.txt
A
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/plugins/document-open-expected.txt
A
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-mac/LayoutTests/plugins/window-open-expected.txt
A
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/plugins/document-open-expected.txt
A
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/data/layout_tests/platform/chromium-win/LayoutTests/plugins/window-open-expected.txt
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/plugin_stream_url.cc?r1=31991&r2=31990
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/plugins/plugin_string_stream.cc?r1=31991&r2=31990
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/npapi_layout_test_plugin/PluginObject.cpp?r1=31991&r2=31990
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/npapi_layout_test_plugin/PluginObject.h?r1=31991&r2=31990
M
http://src.chromium.org/viewvc/chrome/trunk/src/webkit/tools/npapi_layout_test_plugin/main.cpp?r1=31991&r2=31990
This CL fixes the document-open.html and window-open.html plugin layout
tests. These were landed in webkit
as fixes for bug https://bugs.webkit.org/show_bug.cgi?id=31067
The layout test plugin changes are on similar lines as the version upstream.
We need to rebaseline the expectations as the line numbers differ in test
shell and dumprendertree.
The document-open.html crashes in test_shell as this test causes the
existing document to be taken down
which takes down the plugin instance and the associated plugin stream. This
works in the webkit plugin
implementation as they grab a reference on the plugin stream before calling
into the plugin to protect
from the stream being destroyed.
Our fix is on similar lines.
Bug=27164
Review URL: http://codereview.chromium.org/393017
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
