Updates:
        Cc: m...@chromium.org

Comment #8 on issue 27145 by tha...@chromium.org: Crash in http cache while  
pages are loading
http://code.google.com/p/chromium/issues/detail?id=27145

rvargas: Are you sure? The code that you quoted in its entirety:

   if (renderWidgetHostView_->render_widget_host_) {
     RenderWidgetHost* widgetHost =  
renderWidgetHostView_->render_widget_host_;
     EditCommands editCommands;
     [EditCommandMatcher matchEditCommands:&editCommands forEvent:theEvent];
     if (!editCommands.empty())
       widgetHost->ForwardEditCommandsForNextKeyEvent(editCommands);
     widgetHost->ForwardKeyboardEvent(event);
   }

if |widgetHost| is != NULL when the if is entered, then  
renderWidgetHostView_-
> render_widget_host_ should still be != NULL in the ForwardKeyboardEvent()  
> line too
as far as I understand (and the gtk version doesn't check this twice  
either). Neither
matchEditCommands nor ForwardEditCommandsForNextKeyEvent() run an event loop
or do anything else that could change render_widget_host_.

Sadly, I can't repro this bug (r31985).

+mark, who knows this code a bit too.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

-- 
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs

Reply via email to