Comment #4 on issue 25528 by bugdro...@chromium.org: Reimplement app shortcuts natively (not using gears) http://code.google.com/p/chromium/issues/detail?id=25528
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=32165
------------------------------------------------------------------------
r32165 | xiy...@chromium.org | 2009-11-17 00:39:51 -0800 (Tue, 17 Nov 2009)
| 28 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/file_util.h?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/base/file_util_win.cc?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/app/generated_resources.grd?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.cc?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser.h?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/browser_window.h?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_cocoa.h?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/browser_window_cocoa.mm?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.cc?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/browser_window_gtk.h?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/shell_integration.h?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.cc?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents.h?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/tab_contents/tab_contents_delegate.h?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/browser_dialogs.h?r1=32165&r2=32164
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/create_application_shortcut_view.cc
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/create_application_shortcut_view.h
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_view.cc?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/views/frame/browser_view.h?r1=32165&r2=32164
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/web_applications
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/web_applications/web_app.cc
A
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/web_applications/web_app.h
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/chrome.gyp?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_constants.cc?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/chrome_constants.h?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.cc?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/common/pref_names.h?r1=32165&r2=32164
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/test/test_browser_window.h?r1=32165&r2=32164
Implement web app shortcuts natively per issue 25528
- Implement a CreateApplicationShortcutView similar to the current
Gears-based one;
- Add a few profile prefs to persist user's last checked shortcut locations
- Implement a web_app::CreateShortcut that stores icon under "<profile>/Web
Applications"
in a similar layout as gears (i.e.
<host>/<scheme_port>/<web_app_title>.ico) and calls
file_util code to creates shortcut on Windows;
- Add Win7 taskbar pin/unpin support function to file_util;
- Update TabContents to replace gears with new code;
Note:
- Gears dialog is modaless but this one is a modal dialog.
- Gear's icon store is not migrated because gears icons
could still be used by shortcuts created by gears and
thus we could not delete them even after migration. And we
are not using the local ico files in the dialog even if
they exists.
- New CreateApplicationShortcutView is included when
TOOLKIT_VIEW is defined. However on platforms other
than Windows, the actual CreateShortCut code is not
implemented. Right now it calls ShellIntegration's
CreateDesktopShort if OS_LINUX is defined and
NOTREACHED() for other platforms.
BUG=25528
TEST=Verify the new UI provides the same functionality as gears under
XP/Vista and support pinning on Win 7.
Review URL: http://codereview.chromium.org/372012
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
