Comment #5 on issue 21040 by bugdro...@chromium.org: Mock media filters  
should use mocked media_format()
http://code.google.com/p/chromium/issues/detail?id=21040

The following revision refers to this bug:
     http://src.chromium.org/viewvc/chrome?view=rev&revision=32267

------------------------------------------------------------------------
r32267 | scher...@chromium.org | 2009-11-17 19:05:02 -0800 (Tue, 17 Nov  
2009) | 11 lines
Changed paths:
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/AUTHORS?r1=32267&r2=32266
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/renderer/media/audio_renderer_impl_unittest.cc?r1=32267&r2=32266
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/mock_filters.h?r1=32267&r2=32266
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/media/base/pipeline_impl_unittest.cc?r1=32267&r2=32266
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/audio_renderer_base_unittest.cc?r1=32267&r2=32266
    M  
http://src.chromium.org/viewvc/chrome/trunk/src/media/filters/video_renderer_base_unittest.cc?r1=32267&r2=32266

Replace hard-coded media_format() methods with Google Mock methods declared  
in mock_filters.h.

Updated unit tests accordingly.

Patch by Dominic Jodoin <dominic.jod...@gmail.com>

BUG=21040
TEST=Run the media_unittests and AudioRendererImplTest test suite in  
unit_tests. Ensure there is no Google Mock failures and that all tests are  
passing.

Review URL: http://codereview.chromium.org/404016

------------------------------------------------------------------------


--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

-- 
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs

Reply via email to