Comment #3 on issue 27855 by [email protected]: Crash in
gtk_chrome_link_button_destroy
http://code.google.com/p/chromium/issues/detail?id=27855
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=32358
------------------------------------------------------------------------
r32358 | [email protected] | 2009-11-18 11:18:49 -0800 (Wed, 18 Nov 2009)
| 12 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/gtk/gtk_chrome_link_button.cc?r1=32358&r2=32357
GTK: fix link button double free.
If set_normal_color was called while native_markup == normal_markup, then
the string could be double freed. To fix this problem and prevent similar
future mistakes, I made native_markup stdup normal_markup instead of just
copying the pointer (the optimization wasn't worth the trickiness). Also, I
cleaned up destruction logic.
BUG=27855
TEST=tried every flavor of chrome link button:
- classic theme
- non classic theme
- gtk theme
- gtk theme system theme that has non-default link text color property
Review URL: http://codereview.chromium.org/400009
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
