Comment #14 on issue 27758 by [email protected]: Crash in extension
popup - AppModalDialog::OnAccept()
http://code.google.com/p/chromium/issues/detail?id=27758
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=32900
------------------------------------------------------------------------
r32900 | [email protected] | 2009-11-23 17:46:47 -0800 (Mon, 23 Nov
2009) | 16 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/app_modal_dialog.cc?r1=32900&r2=32899
M
http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/app_modal_dialog.h?r1=32900&r2=32899
M
http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/extensions/extension_host.h?r1=32900&r2=32899
M
http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/jsmessage_box_client.h?r1=32900&r2=32899
M
http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/tab_contents/tab_contents.h?r1=32900&r2=32899
Merge 32889 - Fix crash when an extension popup shows a JS alert. Showing
the alert takes...
Landing this on for pam. Original issue:
http://codereview.chromium.org/425011/show.
Disable showing JS alerts from popups, because doing so makes the popup
disappear immediately, which has all sorts of unfortunate side effects for
the
poor orphaned alert (see bug for details).
BUG=27758
TEST=create extension with popup, put link with |onclick="alert('test');"|
in
it; install extension, open popup, and click link; see no crash (nor popup)
Review URL: http://codereview.chromium.org/435010
[email protected]
Review URL: http://codereview.chromium.org/435014
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
