Comment #10 on issue 28096 by bugdro...@chromium.org: Handle Histogram lifetimes to avoid premature destruction http://code.google.com/p/chromium/issues/detail?id=28096
The following revision refers to this bug: http://src.chromium.org/viewvc/chrome?view=rev&revision=33185 ------------------------------------------------------------------------ r33185 | u...@chromium.org | 2009-11-25 22:42:37 -0800 (Wed, 25 Nov 2009) | 17 lines Changed paths: M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.cc?r1=33185&r2=33184 M http://src.chromium.org/viewvc/chrome/branches/249/src/chrome/browser/net/websocket_experiment/websocket_experiment_runner.h?r1=33185&r2=33184 Merge 32311 - Hold histograms in static variables instead of allocating heap. If instance variables holding pointers to Histograms, it would cause crash bug when the instance is torn down and the metrics services use and recording of their contents. The current "standard" patten for using Histograms includes making sure that the Histogram instances are not destroyed prematurely, held in static variables. BUG=28096 TEST=none Review URL: http://codereview.chromium.org/404022 tbr=u...@chromium.org Review URL: http://codereview.chromium.org/441027 ------------------------------------------------------------------------ -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings -- Automated mail from issue updates at http://crbug.com/ Subscription options: http://groups.google.com/group/chromium-bugs