Comment #21 on issue 25520 by [email protected]: Create our own FTP LIST parsing code http://code.google.com/p/chromium/issues/detail?id=25520
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=33688
------------------------------------------------------------------------
r33688 | [email protected] | 2009-12-03 08:13:03 -0800 (Thu, 03 Dec
2009) | 11 lines
Changed paths:
A
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/ftp/dir-listing-ls-10
A
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/ftp/dir-listing-ls-10.expected
A
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/ftp/dir-listing-ls-6
A
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/ftp/dir-listing-ls-6.expected
A
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/ftp/dir-listing-ls-7
A
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/ftp/dir-listing-ls-7.expected
A
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/ftp/dir-listing-ls-8
A
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/ftp/dir-listing-ls-8.expected
A
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/ftp/dir-listing-ls-9
A
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/ftp/dir-listing-ls-9.expected
A
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/ftp/dir-listing-vms-5
A
http://src.chromium.org/viewvc/chrome/trunk/src/net/data/ftp/dir-listing-vms-5.expected
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_directory_listing_buffer_unittest.cc?r1=33688&r2=33687
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_directory_listing_parsers.cc?r1=33688&r2=33687
M
http://src.chromium.org/viewvc/chrome/trunk/src/net/ftp/ftp_directory_listing_parsers_unittest.cc?r1=33688&r2=33687
Make new FTP LIST parsing code more robust.
Some highlights:
- more tests (including non-ASCII characters in different encodings)
- handling more variants of "ls" listing
- handling spaces in file names in "ls" listings
TEST=Covered by net_unittests.
BUG=25520
Review URL: http://codereview.chromium.org/449011
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
