Comment #3 on issue 31857 by bugdro...@chromium.org: Bookmark Manager:
Context menus
http://code.google.com/p/chromium/issues/detail?id=31857
The following revision refers to this bug:
http://src.chromium.org/viewvc/chrome?view=rev&revision=35949
------------------------------------------------------------------------
r35949 | s...@chromium.org | 2010-01-11 14:21:22 -0800 (Mon, 11 Jan 2010) |
13 lines
Changed paths:
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_groups_controller.mm?r1=35949&r2=35948
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_manager_controller.h?r1=35949&r2=35948
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_manager_controller.mm?r1=35949&r2=35948
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_tree_controller.mm?r1=35949&r2=35948
M
http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/cocoa/bookmark_tree_controller_pasteboard.mm?r1=35949&r2=35948
Implemented bookmark manager context menus.
BUG=31857
TEST=none
Mike Pinkerton recommended I use the cross-platform menu utilities for
this; I decided not to do that yet, in this patch, for a few reasons:
(1) I'm in the midst of doing heavy refactoring of the tree/list controller
classes in a local branch, so anything I do now would have to get changed a
lot in that branch anyway.
(2) The Windows and GTK bookmark managers don't use them, so there's not
existing common code to hook into. This means I'd have to write all that
code, and presumably retrofit the other platform managers to use it. But we
really want to get this patch into the upcoming (tonight?) dev-channel
build to avoid user confusion.
I have not added a menu to the nib. I've added code to
BookmarkManagerController to create the NSMenu programmatically. I can
switch to the cross-platform utilities after my refactoring.
Another note: Yes, there is some duplication of code between the Groups and
Tree controller classes. I'm not worrying about this because the Groups
controller class is going away completely in my refactoring, so it only has
a few more days to live. :-)
Review URL: http://codereview.chromium.org/549010
------------------------------------------------------------------------
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
