Updates:
Status: Started
Owner: n...@chromium.org
Comment #3 on issue 29899 by n...@chromium.org: Add mime type to SyncNode
interface
http://code.google.com/p/chromium/issues/detail?id=29899
I'm gutting IS_BOOKMARK_OBJECT and plumbing the specifics as we speak, and
doing
basically what you suggest here.
Right now the accessors look like this:
bool IsBookmarkType() {
return entry_.Get(SPECIFICS).HasExtension(sync_pb::bookmark);
}
const sync_pb::BookmarkSpecifics& GetBookmarkSpecifics() {
DCHECK(IsBookmarkType());
return entry_.Get(SPECIFICS).GetExtension(sync_pb::bookmark);
}
void SetBookmarkSpecifics(const sync_pb::BookmarkSpecifics& x) { ... }
An enum may prove useful if there is more than one place where we need to
fan out
on a per-datatype basis; we can add it when we see the need. I think
having the
enum values match the extension tag values would be a Good Thing.
I'm right now planning not to expose the raw, extensible EntitySpecifics
through
syncapi, mostly as a convenience to the users. But we'll see.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--
Automated mail from issue updates at http://crbug.com/
Subscription options: http://groups.google.com/group/chromium-bugs
