Hi Peter, On Wed, Oct 8, 2008 at 8:06 PM, Peter Kasting <[EMAIL PROTECTED]> wrote:
> Two recommendations for folks participating in code reviews using Rietveld > (codereview.chromium.org): > (2) When reviewing a patch or responding to review comments, use the same > Publish+Mail Comments link to converse. Tempting as it is, try to avoid > using your mail client to respond to the comment emails directly, because > that doesn't put your comments online on the issue where others can see and > respond to them later. This helps avoid strange half-broken threads when > someone else tries to look over and comment on an issue after it's been in > review for a while. > > Feel free to share other "best practices" you've encountered. > One small thing that makes responding in Publish+Mail Comments a bit awkward is the width of the message text field. Could we perhaps increase this to something closer to the gmail message field width? Also, the values in the reviewers field default to just the user name(s). When I submit the message I get an error saying that the reviewer(s) don't exist, or something to that effect. I need to add @chromium.org to each one before it will let me send. > > PK > Regards, Marshall --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to chromium-dev@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
