Yes, very unlucky. Thanks Brett!
On Fri, Oct 31, 2008 at 12:08 PM, Brett Wilson <[EMAIL PROTECTED]> wrote: > > On Oct 31, 6:53 am, "Lucila Sanjurjo" <[EMAIL PROTECTED]> wrote: > > Thanks, I think maybe this version fails to compile. > > > > Last week I have synced to the last version of the code. This version > seems > > to have an issue when pressing TAB key, it throws an access violation. > > > > void WebContentsViewWin::OnPaint(HDC junk_dc) { > > if (web_contents_->render_view_host() && > > !web_contents_->render_view_host()->IsRenderViewLive()) { > > <--------------- > > if (!web_contents_->sad_tab_.get()) > > web_contents_->sad_tab_.reset(new SadTabView); > > CRect cr; > > GetClientRect(&cr); > > web_contents_->sad_tab_->SetBounds(gfx::Rect(cr)); > > ChromeCanvasPaint canvas(GetHWND(), true); > > web_contents_->sad_tab_->ProcessPaint(&canvas); > > return; > > } > > > > Looking at web_contents_ I can see that render_view_factory_ is NULL. > > This is a known issue? > > Sync again. I broke this last week, it was broken for about half a > day, so you just got an unlucky build. > > Brett > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to chromium-dev@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---