On Sat, Dec 20, 2008 at 05:27, Mohamed Mansour <[email protected]>wrote:
> Hey Mark, > I usually do the following when I submit patches, should I change it? > > BUG=1234 (http://crbug.com/1234) > > I initially thought we have to include BUG=1234, cause the developers wiki > stated so, I included the url since I saw Ben was using it and it autolinks. > What I am trying to say, I included both. > Either form is fine, and you can just use one. The URL is probably better because it will autolink in some contexts: BUG= http://crbug.com/1234, http://crbug.com/2345 > > BTW, could someone upload the gcl script and include the BUG= within the > template? It isn't int he svn so I could submit the patch to do that. > Instead of typing it all the time. > I'll look into that. > > > > On Sat, Dec 20, 2008 at 4:34 AM, Mark Larson (Google) > <[email protected]>wrote: > >> >> >> On Sat, Dec 20, 2008 at 01:20, Ben Goodger (Google) <[email protected]>wrote: >> >>> >>> I fill out my changelogs like this: >>> >>> http://crbug.com/### >>> >>> it becomes auto-linkified in the email, and the hostname gives away >>> what its intent is. >> >> >> Good point. I've added a rule to look for ((?i)crbug\.com\/\d+) in any >> line, which should catch these references as well. >> >> More feedback welcome, >> Mark >> >> >>> >>> >>> -Ben >>> >>> On Sat, Dec 20, 2008 at 1:17 AM, Mark Larson (Google) <[email protected]> >>> wrote: >>> > I've created a script that watches checkins and updates bugs that the >>> > checkin mentions. >>> > If you want to update a bug with a change, add >>> > BUG=nnnn >>> > >>> > to the log entry. >>> > See http://src.chromium.org/viewvc/chrome?view=rev&revision=7301 for >>> an >>> > example. You need to add BUG= to your codereview description >>> > (@codereview.chromium.org or by using gcl change). >>> > Also see http://crbug.com/4878 to see the bug comment that r7301 >>> generated. >>> > Note to Googlers: BUG=nnnnnn where nnnnnnn > 500000 will update the >>> internal >>> > b/nnnnnn bug. >>> > I hope this will help us get a more accurate mapping from code changes >>> to >>> > bugs and make it easier to track bug fixes in the issue tracker. >>> > --Mark >>> > >>> > > >>> > >>> >>> >>> >> >> >> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Chromium-dev" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/chromium-dev?hl=en -~----------~----~----~----~------~----~------~--~---
