Hi, Feel free to send me the review.
The important part is to assign the review to someone knowledgeable in the respective area of the code, all the people Dean listed would be a good match in this case. In general, if you have any doubts about who to send a review to, you can ask on irc, on chromium-dev, or look at who the last people to touch that area of the code are (as you did in this case). Best regards, Jeremy On Sun, Jan 18, 2009 at 4:01 PM, Naoki Takano <takano.na...@gmail.com>wrote: > Hi Dean, > > Thank you for your response. > > In the web page where you suggested, I read 'You can also just request > review from chromium-revi...@googlegroups.com <chrome-revi...@google.com>'. > So can anybody review my source code ? > > Otr the source code which I changed is originally change by > jer...@chromium.org, so do I have to ask him to review my source code > directly ? > > Thanks, > > > On Sun, Jan 18, 2009 at 9:01 AM, Dean McNamee <de...@chromium.org> wrote: > >> Hi! >> >> The way we do patch reviews is through n web tool called Rietveld: >> >> http://codereview.chromium.org/ >> >> The following page gives you an overview on how to create a >> changelist, and upload it for review: >> >> http://dev.chromium.org/developers/contributing-code >> >> I believe all of these tools and directions should more or less be the >> same for the Mac. Once you upload it, you can assign some reviewers >> who will look at your patch. To get started, I'd suggest setting the >> reviewers and sending the review to: de...@chromium.org, >> m...@chromium.org, pinker...@chromium.org. >> >> Thanks >> -- dean >> >> On Sun, Jan 18, 2009 at 7:18 AM, Naoki Takano <takano.na...@gmail.com> >> wrote: >> > Hi, >> > >> > My name is honten. >> > I want to try to help Mac version bug fixing and implementation. >> > I try to start to fix 3661, because it's much easier to understand an to >> > compare the function with Windows implementation. >> > >> > At first, I made patch for process_mac_util.mm because I found "not >> > implemeted" message while I'm running net_unittests. >> > After I finish the implementaion, I run base_unittests. It looks fine. >> > >> > (Actually I want to try to fix UI bugs but it's hard to understand what >> is >> > bug from Wiki and bug report...) >> > >> > Could you review my patch ? >> > >> > Thanks, >> > >> > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
