I think we can simplify code in another way: if the "recursive" watch doesn't have to add watches for newly created directories in the subtree and remove watches for deleted dirs (so we just scan the subtree when adding initial watch, and don't react to dorectory structure changes), then the code is quite simple.
Just a note: I'm reviewing patch by j.dinata at http://codereview.chromium.org/52005 . I recommended him to split the patch, and I plan to land the simplified version (see above) first, then work on the "full" version. Of course before the check-in I'll ensure that another Chromium developer also reviews the patch. Paweł On Fri, Apr 17, 2009 at 21:11, Evan Martin <e...@chromium.org> wrote: > > I added DirectoryWatcher so that you could edit a script on disk and > Chromium would automatically refresh its in-memory cache of scripts. > > In the extensions world, do you still use this pattern? Do you need > to watch subdirectories as well? > > We have this bug to follow the Windows behavior > http://code.google.com/p/chromium/issues/detail?id=8968 > but there's a bunch of code and I'd like to be certain it's necessary. > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
