1. Naming's arbitrary. The name "hanger window" comes from an earlier design
idea where the clear window was sized only 10 px high, and was the "hanger"
upon which the sheet hung. Once I got the idea that I could also use it to
block input to the underlying view, I guess it outgrew the name. (shrug)
2. It was made separable just so I could easily move it from the POC to
Chromium, but I'm open to GTMing it. Dave, are there any features you'd like
to see?
Avi
On Thu, May 7, 2009 at 7:49 AM, Mike Pinkerton <pinker...@chromium.org>wrote:
> I dig it! NICE!
>
> It's similar to the overlay window trick we use for tab dragging
> between windows. Maybe for consistency you should call the "hanger"
> window the "overlay" window?
>
> Is there any way we can keep this generic and put it into GTM?
>
> On Thu, May 7, 2009 at 8:46 AM, Amanda Walker <ama...@chromium.org> wrote:
> > That's cleaner than I expected, and the behavior looks right. Nice
> > job! I vote for continuing with this approach.
> >
> > --Amanda
> >
> > On Thu, May 7, 2009 at 12:17 AM, Avi Drissman <a...@google.com> wrote:
> >> OK, so attached is my proof of concept. The code is pretty clear, though
> if
> >> you have questions, please let me know.
> >>
> >> +maf: Your offhand comment about tabs being subwindows led me to this
> >> implementation; thanks!
> >> +dmac: What do you think? I'll send the DTS incident back to you
> tomorrow.
> >>
> >> Avi
> >>
> >> On Tue, May 5, 2009 at 2:40 PM, Avi Drissman <a...@google.com> wrote:
> >>>
> >>> Having signed up for the login dialog, I'm seeing that it's a pretty
> >>> interesting subject. If you try out a page with HTTP auth, you'll see
> that
> >>> you get what looks like a dialog for the username and password. But if
> you
> >>> click around, you find that you can switch tabs, and that the dialog is
> >>> tab-modal. In fact, the UI test has a test
> (LoginPromptTest.TestTwoAuths) to
> >>> make sure that you can have two auths going on at once.
> >>>
> >>> I was thinking about doing this as a sheet, but that's window-modal and
> of
> >>> less functionality. I can play games with dialogs (making them child
> windows
> >>> and/or hiding/showing along with the tab) but that gets to be less
> Mac/like.
> >>>
> >>> As I type this I wonder if we can get a sheet to come down under the
> tab
> >>> bar and hide/show it with the tab. Would that be good UI-wise?
> >>>
> >>> And of course, I'd probably retrofit the file picker to do that too.
> >>>
> >>> Thoughts?
> >>>
> >>> Avi
> >>
> >>
> >
>
>
>
> --
> Mike Pinkerton
> Mac Weenie
> pinker...@google.com
>
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
