Awesome, good to know. For now I will keep that message: http://codereview.chromium.org/115971/diff/1007/1008
And do another CL so one of the internal contributors can commit it cause it requires a clobber . I don't know how to clobber the build bot. Thanks! -- Mohamed Mansour On Sat, May 30, 2009 at 6:30 PM, Peter Kasting <[email protected]>wrote: > On Sat, May 30, 2009 at 3:26 PM, Mohamed Mansour <[email protected] > > wrote: > >> "Manage pop-ups" come from the generated_resources.h for >> IDS_POPUPS_UNBLOCKED but the one that is needed is IDS_POPUPS_BLOCKED_COUNT >> I really don't know why it is failing. I deleted one message from >> generated_resources.grd which wans't needed any more. And thakis pointed out >> that by deleting IDS_OPTIONS_FONTSANDLANGUAGES_GROUP_NAME, the resources >> file might not have been recompiled correctly or related to gyp-changes and >> grd. >> > > That's right. The bots don't pick up on .grd changes like this correctly, > so you need to clobber the build bots on checking something like this in. > > PK > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
