On Fri, Jun 19, 2009 at 11:15 AM, Mike Pinkerton <pinker...@chromium.org>wrote:
> On Fri, Jun 19, 2009 at 2:11 PM, Peter Kasting<pkast...@google.com> wrote:
> > On Fri, Jun 19, 2009 at 11:07 AM, Nicolas Sylvain <nsylv...@chromium.org
> >
> > wrote:
> >>
> >> We should say that we prefer "#if defined(OS_WIN)" over "#ifdef
> OS_WIN".
> >
> > In general, you should always prefer "#if defined(FOO)" over "#ifdef
> FOO",
> > e.g. because you can add "|| defined(BAR)" to the former later.
> > PK
>
> This is already documented in our Chromium coding style guide. Do we
> need to replicate it?
Oops. It was not there when I look at the coding style a long time ago..
Nevermind!
Thanks
Nicolas
>
>
> --
> Mike Pinkerton
> Mac Weenie
> pinker...@google.com
>
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
