On Thu, Jun 25, 2009 at 7:03 AM, Evan Martin <e...@chromium.org> wrote:
> On Thu, Jun 25, 2009 at 6:27 AM, Nicolas Sylvain<nsylv...@chromium.org> > wrote: > > > > > > On Thu, Jun 25, 2009 at 5:27 AM, Dean McNamee <de...@chromium.org> > wrote: > >> > >> I just took a look at what was happening on one of the Linux > >> buildbots. It looks like we completely clear the env and just > >> explicitly set a few things. We need to add LANG=en_US.UTF-8 to that > >> list of things. Any takers? > > > > I can add LANG to the list of whitelisted env var to keep. Would that > work? > > If any of our tests depend on a particular locale, we should have them > set that locale first. > man setlocale (and man 7 locale) > Be sure to reset the locale in the tear-down. > I made the bot at least keep the current lang, but I agree that it should be set by the test if it needs to be something specific. Nicolas --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---