I can help you out this afternoon if necessary.
Dimitri Glazkov wrote:
> I agree -- if weren't such a Python n00b I'd already have a patch. I
> am looking through it now....
>
> :DG<
>
> On Mon, Jul 6, 2009 at 8:19 AM, Mark Mentovai<m...@chromium.org> wrote:
>> = needs to be quoted if it occurs in the first word passed to the
>> shell (or, if the first word was a variable assignment, the second
>> word, and so on). EncodePOSIXShellArgument doesn't know or care
>> whether it's working with the first word or a subsequent one.
>>
>> I'm pretty much convinced that whatever is going on here ought to be
>> dealt with in webkit/build/rule_binding.py.
>>
>> Mark
>>
>> Ben Laurie wrote:
>>>
>>> On Mon, Jul 6, 2009 at 3:43 PM, Dimitri Glazkov<dglaz...@google.com> wrote:
>>>>
>>>> Apply this locally, if you want to get rid of them:
>>>>
>>>> diff --git a/WebCore/bindings/scripts/IDLParser.pm
>>>> b/WebCore/bindings/scripts/IDLParser.pm
>>>> index c4cb041..0a6832f 100644
>>>> --- a/WebCore/bindings/scripts/IDLParser.pm
>>>> +++ b/WebCore/bindings/scripts/IDLParser.pm
>>>> @@ -75,7 +75,7 @@ sub Parse
>>>>
>>>> print " | *** Starting to parse $fileName...\n |\n" unless $beQuiet;
>>>>
>>>> - open2(\*PP_OUT, \*PP_IN, split(' ', $preprocessor), (map { "-D$_"
>>>> } split(' ', $defines)), $
>>>> + open2(\*PP_OUT, \*PP_IN, split(' ', $preprocessor), (map {
>>>> s/"//g; "-D$_" } split(' ', $defi
>>>> close PP_IN;
>>>> my @documentContent = <PP_OUT>;
>>>> close PP_OUT;
>>>>
>>>> Unfortunately, this is probably not the proper fix -- it deals with
>>>> the symptom, not the cause.
>>>
>>> The cause is gyp.common.EncodePOSIXShellArgument, which thinks the
>>> presence of an '=' means the argument needs to be quoted. I am less
>>> than convinced this is really true, no matter what POSIX says :-)
>>>
>>>>
>>>> :DG<
>>>>
>>>> On Mon, Jul 6, 2009 at 7:29 AM, Evan Martin<e...@chromium.org> wrote:
>>>>>
>>>>> http://code.google.com/p/chromium/issues/detail?id=15904
>>>>> Something went wrong with quoting when some v8-related script was
>>>>> upstreamed. Dimitri's working on it.
>>>>>
>>>>> On Mon, Jul 6, 2009 at 7:18 AM, Mike Pinkerton<pinker...@chromium.org>
>>>>> wrote:
>>>>>>
>>>>>> When I try to build today, I get 2000 errors of the form:
>>>>>>
>>>>>> <command line>:1:1: error: macro names must be identifiers
>>>>>>
>>>>>> when building WebCore bindings. Others have complained of similar
>>>>>> errors on Linux. What's going on here? Reports are that it seems to
>>>>>> still "build" correctly, but this really throws XCode for a loop.
>>>>>>
>>>>>> This was introduced at r19816.
>>>>>>
>>>>>> --
>>>>>> Mike Pinkerton
>>>>>> Mac Weenie
>>>>>> pinker...@google.com
>>>>>>
>>>>>> >
>>>>>>
>>>>>
>>>>> >
>>>>>
>>>>
>>>> >
>>>>
>>>
>>> >>>
>>>
>>
>
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
