Hi I thought none of the hex stuff was supposed be compiled. Line 183 does #define NO_HEX_FP but there is some interesting interaction between INFNAN_CHECK, No_Hex_NaN and Need_Hexdig which might result in it compiling for you. Hmmm ....
Try adding #define No_Hex_Nan after #define NO_HEX_FP perhaps? --Craig On Mon, Jul 13, 2009 at 7:18 AM, Evan Martin<[email protected]> wrote: > > On Sun, Jul 12, 2009 at 8:38 PM, empriser<[email protected]> wrote: >> third_party/dmg_fp/dtoa.cc: In function 'void dmg_fp::hexnan >> (dmg_fp::U*, const char**)': >> third_party/dmg_fp/dtoa.cc:1558: warning: array subscript has type >> 'char' > > The line in question is: > if (!hexdig['0']) > So yes, the warning is correct. What compiler are you using? I am > curious why this hasn't affected us already. > > It looks like we've already patched around some warnings in this code, > so maybe we need to do more of that. > http://src.chromium.org/viewvc/chrome/trunk/src/base/third_party/dmg_fp/README.chromium > > (BTW, I also looked into whether our copy of this file is old, but we > match the newest version linked from the author's home page.) > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: [email protected] View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
