On Wed, Jul 22, 2009 at 2:58 PM, Adam Langley<a...@chromium.org> wrote:
>
> On Wed, Jul 22, 2009 at 9:50 PM, Darin Fisher<da...@google.com> wrote:
>> Personally, I much prefer the #include <png.h> approach. Is it a problem to
>> wait for the GYP change that makes this possible?
>
> Well, I could make it #include <png.h> everywhere and then add an
> include directory in the case that we aren't using the system libpng.
> If folks are happy with that (it goes against our usual policy of
> avoid -I flags), then that's cool.
Looks like you made this change in the patch, although I don't see the
include rule update for chrome.gyp.
I guess some obvious ones like <png.h> and <bzlib.h> are fine. Some of
them give me pause, like <event.h>, which we also have in views and
may also have in other parts of the system, and this will cause
compilation problems on Windows (I think). "event.h" just isn't very
clear to me either.
You could also have a define USE_SYSTEM_LIBRARIES and you write:
#ifdef USE_SYSTEM_LIBRARIES
#include <png.h>
#else
#include "third_party/libpng/png.h"
#endif
Which I find much more readable than your "magic" define for the png filename.
Brett
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
