Nitpick: Always include config.h in an implementation file, never in a
header file.(http://webkit.org/coding/coding-style.html)
~Nate, who has gotten dinged in reviews repeatedly for that mistake.
On Fri, Aug 7, 2009 at 10:10 AM, Dimitri Glazkov <dglaz...@chromium.org>wrote:
>
> This is more of a WebKit-land question, rather than Chromium-land
> question. And yes, it's basically a rule on WebKit-land -- always
> include config.h.
>
> You may want to raise the idea of a presubmit check on webkit-dev.
>
> :DG<
>
> On Fri, Aug 7, 2009 at 5:48 AM, Ben Laurie<b...@chromium.org> wrote:
> >
> > I just got bitten by failing to
> >
> > #include "config.h"
> >
> > in a file. This caused that file to have a different version of KURL
> > from the rest of the code (it did not use GOOGLEURL, whereas the rest
> > did) with predictably bad results.
> >
> > I'm wondering whether either:
> >
> > a) Including config.h wherever its needed, or
> >
> > b) Having a test to check it is included spread about the place
> >
> > is a good idea? Certainly would've saved me some time.
> >
> > >
> >
>
> >
>
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
