I'm personally fine with these numbers, thanks for generating them. I guess one additional benefit is that there'll be less release-specific build breaks.
On Fri, Sep 4, 2009 at 11:50 AM, Marc-Antoine Ruel <mar...@chromium.org>wrote: > - quad core > - without IB > - VS2005 (without /MP, with incremental linking) > - 4 parallel builds > > Stock build > 53:40 > 54:16 > best = 3220 seconds > > PCH-less builds > 55:44 > 57:09 > best = 3344 seconds > > That's roughly a 4% total build regression. This will be even less > significant with /MP (automatic on VS2008), without incremental > linking (only x86 OS) or with IB. > > Any concerns? > > M-A > > On Thu, Sep 3, 2009 at 10:35 PM, Darin Fisher<da...@chromium.org> wrote: > > Sorry for being late to the party, but I don't understand why this is the > > best solution to the problem. Why not just have a gyp variable to > disable > > precompiled headers and then set that variable in the ~/.gyp/include.gypi > > file on the try bots? > > This should be an easy thing to do since we already disable precompiled > > headers in release builds. > > My assumption is that precompiled headers help speed up debug builds for > > developers. > > -Darin > > > > On Thu, Sep 3, 2009 at 1:16 PM, Marc-Antoine Ruel <mar...@chromium.org> > > wrote: > >> > >> If anyone has concerns, please speak up within the next few minutes. > >> > >> M-A > >> > >> On Thu, Sep 3, 2009 at 12:51 PM, <mar...@chromium.org> wrote: > >> > Reviewers: Nicolas Sylvain, > >> > > >> > Message: > >> > Depending on the compile time difference on Chromium XP, I'll choose > to > >> > either (selectively or totally) revert the patch or not. > >> > > >> > Description: > >> > Delete all precompiled support. It is causing more harm than good, > >> > especially when define changes. > >> > > >> > TEST=none > >> > BUG=20889 > >> > > >> > Please review this at http://codereview.chromium.org/171118 > >> > > >> > Affected files: > >> > M chrome/browser/views/about_ipc_dialog.h > >> > M chrome/browser/views/about_ipc_dialog.cc > >> > M chrome/chrome.gyp > >> > D chrome/tools/build/win/precompiled.h > >> > D chrome/tools/build/win/precompiled.cc > >> > D chrome/tools/build/win/precompiled.vsprops > >> > D chrome/tools/build/win/precompiled_wtl.h > >> > D chrome/tools/build/win/precompiled_wtl.cc > >> > D chrome/tools/build/win/precompiled_wtl.vsprops > >> > D net/build/precompiled_net.h > >> > D net/build/precompiled_net.cc > >> > M net/net.gyp > >> > M sandbox/sandbox.gyp > >> > D sandbox/sandbox_poc/pocdll/stdafx.h > >> > D sandbox/sandbox_poc/pocdll/stdafx.cc > >> > D sandbox/sandbox_poc/stdafx.h > >> > D sandbox/sandbox_poc/stdafx.cc > >> > D sandbox/src/stdafx.h > >> > D sandbox/src/stdafx.cc > >> > D sandbox/tests/integration_tests/stdafx.h > >> > D sandbox/tests/integration_tests/stdafx.cc > >> > D sandbox/tests/unit_tests/stdafx.h > >> > D sandbox/tests/unit_tests/stdafx.cc > >> > D sandbox/tests/validation_tests/stdafx.h > >> > D sandbox/tests/validation_tests/stdafx.cc > >> > D sandbox/tools/finder/stdafx.h > >> > D sandbox/tools/finder/stdafx.cc > >> > D sandbox/tools/launcher/stdafx.h > >> > D sandbox/tools/launcher/stdafx.cc > >> > D skia/precompiled.cc > >> > M skia/skia.gyp > >> > D tools/measure_page_load_time/ie_bho/stdafx.h > >> > D tools/measure_page_load_time/ie_bho/stdafx.cpp > >> > D webkit/build/V8Bindings/precompiled_v8bindings.h > >> > D webkit/build/V8Bindings/precompiled_v8bindings.cpp > >> > D webkit/build/precompiled_webkit.h > >> > D webkit/build/precompiled_webkit.cc > >> > D webkit/build/precompiled_webkit_c.c > >> > M webkit/webkit.gyp > >> > > >> > > >> > > >> > >> > >> > > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
