On Tue, Sep 15, 2009 at 4:26 AM, Dirk Pranke <dpra...@chromium.org> wrote:
> I have just landed a patch that enables us to run layout tests on
> Vista as well as XP.
>
Thanks for doing this! Needing to run the tests on a 32bit XP machine sucks.
I don't think we can call running the tests on Vista supported until the
tooling people rely on also supports it. Otherwise, we are causing more
burden than benefit (e.g. we'll essentially be requiring everyone to have
both Vista and XP machines). Things that come to mind:
- Vista bot on the primary (non-fyi) waterfall
- Vista layout test try server
- Vista canary bot for tip of tree webkit
- Rebaseline tool support
We'll also need the same before we consider Win7 supported. I'm OK with
adding Win7 baselines and a Win7 fyi bot before that, but the team should
not be expected to support it until the tools do.
It's not clear to me what our desired end result should be. Do we need a
full set of bots for WebKit Vista and WebKit Win7? Is just having release
bots for each enough? The waterfall is already very crowded. My first
intuition is that we should have release and debug bots for the latest
supported platform (which will soon be Vista) and just release bots for
other platforms (definitely XP, what about Win7?).
Also, the
checkin involved updating > 700 images, so I didn't have anyone but me
> review them.
>
I'm confused by this. Are you saying you didn't get this code reviewed? If
so, why not? Can you provide a link to the checkin so it can get reviewed?
Test rebaselines should not get checked in without review. Simple, mistakes
are made all the time.
Ojan
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
