On Tue, Oct 6, 2009 at 11:09 PM, Jacob Mandelson <ja...@mandelson.org> wrote:
> On Tue, Oct 06, 2009 at 09:19:49PM +0200, Craig Schlenter wrote:
>> On Tue, Oct 6, 2009 at 8:14 PM, Craig Schlenter
>> <craig.schlen...@gmail.com> wrote:
>> > On Tue, Oct 6, 2009 at 7:51 PM, Jacob Mandelson <ja...@mandelson.org>
>> > wrote:
>> >> On Tue, Oct 06, 2009 at 07:39:14PM +0200, Craig Schlenter wrote:
>> >>> On Tue, Oct 6, 2009 at 6:58 PM, Evan Martin <e...@chromium.org> wrote:
>> >>> >
>> >>> > On Tue, Oct 6, 2009 at 9:21 AM, Jacob Mandelson <ja...@mandelson.org>
>> >>> > wrote:
>> >>> >> I tried this, and it does indeed link far, far faster!
>> >>> >> However, I got errors about RegisterInternalNaClPlugin():
>> >>> >> /mnt/sda4/media/contrib/chrome2/home/chrome-svn/tarball/chromium/src/sconsbuild/Debug/lib/librenderer.so:
>> >>> >> undefined reference to `RegisterInternalNaClPlugin(bool (*)(int,
>> >>> >> int*))'
>> >>> >> (Also one for libbrowser.so)
>> >>> >
>> >>> > In general, the shared link breaks frequently. Whenever I work from a
>> >>> > cafe or wherever from my laptop, I usually will do a TBR commit or two
>> >>> > to fix the shared link.
>> >>>
>> >>> The shared build is working perfectly for me FWIW but that is on 32 bit.
>> >>>
>> >>> Are you on 64 bit or do you have any special gyp variables etc. set?
>> >>
>> >> I'm on 32-bit. Only gyp changes from stock I have are:
>> >> {'variables': {
>> >> 'library': 'shared_library',
>> >> 'remove_webcore_debug_symbols': 1,
>> >> }}
>> >
>> > Ah, you're doing a debug build then? I have only tested release recently.
>> >
>> > I'll poke at a debug build tomorrow and try to sort it out ...
>>
>> Hmmmmm ... debug build is also fine for me and I'm building with the
>> same gyp variables as you (except that I also have gcc_version=44).
>>
>> If you stick your build into verbose mode can you see if it is linking
>> librenderer.so with libnpGoogleNaClPluginChrome.a? Maybe clobbering,
>> regyping etc. will encourage it to do that.
>>
>> PS. I'm on r28124
>
> I switched to --mode=Release, got strict-aliasing warnings^Werrors, stuck
> on -Wno-strict-aliasing, and it landed back in
> /mnt/sda4/media/contrib/chrome2/home/chrome-svn/tarball/chromium/src/sconsbuild/Release/lib/librenderer.so:
> undefined reference to `RegisterInternalNaClPlugin(bool (*)(int, int*))'
> Running gclient runhooks had no effect here.
>
> Building with --verbose shows the very long link line attached, which
> has [nN][aA][cC][lL] only in -lnacl.
This problem only seems to happen with the scons shared build. The
make build does not have this problem so there seems to be something
different about how the dependencies are being generated with the make
versus scons gyp backends.
--Craig
> gclient revinfo begins with
> src: http://src.chromium.org/svn/trunk/s...@28154;
> (Simpler way to get this?)
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
